Move to setuptools_scm instead of bumpversion. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davesque @Andrew-Chen-Wang This is to make it simpler to ship updates by simply creating and push Git tags (or GitHub releases that do that) to trigger the release process to the Jazzband staging package index. bumpversion - while useful to update static version information - is not super compatible with PyPA's setuptools_scm and the version scheme that was in place wasn't either. As such I've simply removed it for now. |
jezdez
requested review from
Andrew-Chen-Wang and
davesque
and removed request for
Andrew-Chen-Wang
12 tasks
|
Hey @jezdez ! Thanks so much for doing this! I think this is all fine but I'll take a more thorough look when I get home! |
|
Thanks @jezdez for upgrading and working on this repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly things I forgot to add in #397.