Add GitHub actions #269
Add GitHub actions #269
Conversation
There was a problem hiding this comment.
@philipp-siegmantel Thanks for the contribution. It might be a better idea to use Travis instead of GitHub actions. Slight bias because I work with it all the time and like its UI. Additionally, it'll be easier to navigate with the Tox matrices (with the builds individualized for each TOXENV). Lots of other beautiful integrations can also go along with it.
| pip install -e .[dev] | ||
| - name: Test with pytest | ||
| run: | | ||
| pytest |
There was a problem hiding this comment.
This should be using Tox configuration
| # This workflow will install Python dependencies, run tests and lint with a single version of Python | ||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
|
|
||
| name: Python application |
There was a problem hiding this comment.
We'll need to use a Python cache for quick installation of dependencies.
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -e .[dev] | ||
| - name: Test with pytest |
There was a problem hiding this comment.
We also need to test the Sphinx building.
| pip install -e .[dev] | ||
| - name: Test with pytest | ||
| run: | | ||
| pytest |
There was a problem hiding this comment.
Try to also have coverage on success. That's kinda why I like Travis, the on_success part.
|
@philipp-siegmantel It seems like Dave used a Travis configuration (check out this Travis build's configuration) I'm not sure why there was change to CircleCI, but it's a little weird having to clone some of these forked repositories and manually testing. Travis or GitHub actions would work better for checking tests straight from GitHub. Ping @johnthagen: Know when and/or why this change to CircleCI happened? |
|
I don't know why the change happened, I just did a couple minor edits to add support for new DRF versions after the change had already been done. |
|
CircleCI now works, so this won't be necessary anymore. Thanks though! |
|
Ref #382 as this will be helpful in migrating to Jazzband's requirement for GitHub actions |
Github Actions have the upside of showing the results of a CI run directly in the merge request. Reviewing would become simpler.