Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated support Python and Django versions #125

Merged
merged 4 commits into from
Dec 22, 2020

Conversation

smithdc1
Copy link
Contributor

Description

Added support for Python 3.9 and Django 3.1. Support for Python 3.5 has been removed in line with other Jazzband projects.

How Has This Been Tested?

Run tox locally, all tests pass. Also tested with warnings to identify and deprecation warnings. Two items highlighted were removal or url() and the django-admin.py entry point.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #125 (99dd6f0) into master (e165428) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   88.92%   89.28%   +0.35%     
==========================================
  Files          10       10              
  Lines         280      280              
  Branches       31       31              
==========================================
+ Hits          249      250       +1     
+ Misses         23       22       -1     
  Partials        8        8              
Impacted Files Coverage Δ
user_sessions/admin.py 100.00% <ø> (ø)
...er_sessions/management/commands/migratesessions.py 81.25% <ø> (ø)
user_sessions/backends/db.py 91.17% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e165428...99dd6f0. Read the comment docs.

@jezdez
Copy link
Member

jezdez commented Dec 21, 2020

There is a chance that some of this overlaps with #126 😬

@smithdc1
Copy link
Contributor Author

It is ok. I can re-work this once your pr is merged.

@mbeijen mbeijen merged commit 9892add into jazzband:master Dec 22, 2020
@smithdc1
Copy link
Contributor Author

😬 not sure we we were going to merge this quite so quickly.

@mbeijen
Copy link
Contributor

mbeijen commented Dec 22, 2020

@smithdc1 I'm sorry, I misread, I thought you wanted this merged before the github actions PR 😢

Should I revert this one in master?

@smithdc1
Copy link
Contributor Author

Sorry for any confusion.

I'm not sure what @jezdez would prefer from here.

I'm busy for the next few hours but I'm happy to try and raise a pr to his branch to fix the merge conflicts? (I've not looked, but I'm expecting there will be a fair amount).

@jezdez
Copy link
Member

jezdez commented Dec 22, 2020

Sorry for any confusion.

I'm not sure what @jezdez would prefer from here.

I'm busy for the next few hours but I'm happy to try and raise a pr to his branch to fix the merge conflicts? (I've not looked, but I'm expecting there will be a fair amount).

No problem, I'll rebase my PR with the current master. Thanks all!

@smithdc1 smithdc1 deleted the update-versions branch February 10, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants