refactor phone method availability checks #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jpaniagualaconich
force-pushed
the
bugfix/refactor-phone-method-availability-checks
branch
3 times, most recently
from
4e3748d
to
261e8ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 97.83% 97.84%
=======================================
Files 78 78
Lines 3378 3384 +6
Branches 376 384 +8
=======================================
+ Hits 3305 3311 +6
Misses 42 42
Partials 31 31 ☔ View full report in Codecov by Sentry. |
jpaniagualaconich
force-pushed
the
bugfix/refactor-phone-method-availability-checks
branch
4 times, most recently
from
e210f44
to
7954670
Compare
|
Would it be possible to move the TWO_FACTOR_SMS/CALL_GATEWAY settings to base test settings in a separate commit/PR? |
jpaniagualaconich
force-pushed
the
bugfix/refactor-phone-method-availability-checks
branch
2 times, most recently
from
4983f63
to
20dfb4f
Compare
|
@claudep ok, dropped that part. |
claudep
reviewed
Nov 25, 2023
| # This allows for dynamic registration, typically when testing. | ||
| from .method import PhoneCallMethod, SMSMethod | ||
|
|
||
| if getattr(settings, 'TWO_FACTOR_CALL_GATEWAY', None): | ||
| installed_apps = getattr(settings, 'INSTALLED_APPS') or [] | ||
| phone_number_app_installed = 'two_factor.plugins.phonenumber' in installed_apps |
There was a problem hiding this comment.
This method of checking apps presence is brittle (as people may use custom app config which will be named differently). Do you think possible using apps.is_installed() instead?
jpaniagualaconich
force-pushed
the
bugfix/refactor-phone-method-availability-checks
branch
from
20dfb4f
to
5cecf66
Compare
claudep
force-pushed
the
bugfix/refactor-phone-method-availability-checks
branch
from
5cecf66
to
ae795df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #663, fixes #665.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: