Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbotch urls for phone setup and create #656

Merged

Conversation

jpaniagualaconich
Copy link
Contributor

Fixes #655

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #656 (0bec413) into master (d6d8b63) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   95.44%   95.45%   +0.01%     
==========================================
  Files          76       76              
  Lines        3293     3301       +8     
  Branches      377      377              
==========================================
+ Hits         3143     3151       +8     
  Misses        119      119              
  Partials       31       31              
Files Changed Coverage Δ
two_factor/plugins/phonenumber/urls.py 100.00% <ø> (ø)
tests/test_views_phone.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jpaniagualaconich jpaniagualaconich changed the title unbotch urls for phone setup and create (#655) unbotch urls for phone setup and create Sep 10, 2023
@claudep
Copy link
Contributor

claudep commented Sep 10, 2023

Do you know if this has potential backwards compatibility issues? Should any special note added to the changelog?

@claudep
Copy link
Contributor

claudep commented Sep 10, 2023

Oh, sorry, I didn't read the ticket description. Forget my question. However, would it be possible to add a simple regression test?

@jpaniagualaconich
Copy link
Contributor Author

@claudep I added PhoneDeleteTest.test_url_generation and PhoneSetupTest.test_url_generation

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@claudep claudep merged commit 887489f into jazzband:master Sep 10, 2023
7 checks passed
@jpaniagualaconich jpaniagualaconich deleted the bugfix/unbotch-phone-setup-delete branch September 10, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urls for phone setup and delete are botched
2 participants