Fixed Django 1.9 compatibility: Pass views as callables, not as strings #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: tinymce/urls.py
| @@ -1,17 +1,18 @@ | |||
| # Copyright (c) 2008 Joost Cassee | |||
| # Licensed under the terms of the MIT License (see LICENSE.txt) | |||
| from tinymce.views import textareas_js, spell_check, flatpages_link_list, compressor, filebrowser, preview | |||
There was a problem hiding this comment.
Can we do: from tinymce import views and then use views.textareas_js in the url definition?
|
@Natim took your advice into acount in the last commit |
|
Thanks. |
Natim
added a commit
that referenced
this pull request
Dec 23, 2015
Fixed Django 1.9 compatibility: Pass views as callables, not as strings
|
Released with in django-tinymce 2.1.0 |
|
That was my first contibution to a django app :D thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
tinymce/urls.py
Fixes #145