Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build and workflow job name. #768

Merged
merged 2 commits into from
Nov 14, 2021
Merged

Fix doc build and workflow job name. #768

merged 2 commits into from
Nov 14, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Nov 14, 2021

I've noticed that the documentation build was broken after looking into the 2.0.0 release and found it to be related to sphinx-doc/sphinx#9811, one of the many incarnations of docutils 0.18 containing breaking changes for Sphinx. This pins to docutils<0.18 to work around it for now.

I've also took the liberty to enable pull request building for the docs via Read The Docs, so we see build issues earlier, see the pull request jobs/checks below. The preview is here: https://django-taggit--768.org.readthedocs.build/en/768/

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #768 (ae5017a) into master (cfca412) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #768   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files           9        9           
  Lines         712      712           
  Branches      111      111           
=======================================
  Hits          643      643           
  Misses         45       45           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfca412...ae5017a. Read the comment docs.

@jezdez jezdez changed the title Fix doc build. Fix doc build and workflow job name. Nov 14, 2021
@jezdez jezdez merged commit 4f29996 into master Nov 14, 2021
@jezdez
Copy link
Member Author

jezdez commented Nov 14, 2021

Thanks @auvipy!

@jezdez jezdez deleted the pin-docutils branch November 14, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants