Version upgrade #34
Open
Version upgrade #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also includes updates for documentation and packaging
| @@ -0,0 +1,48 @@ | |||
| [project] | |||
| name = "django-superform4" | |||
There was a problem hiding this comment.
Do you explicitly want to change the project name?
I am asking since this is only about adding support for recent Python and Django versions and not about an architectural change in the project.
There was a problem hiding this comment.
My recommendation would be to stick with the same project name.
| @@ -34,14 +34,15 @@ def test_it_is_nonzero_for_empty_formsets(self): | |||
| form = AccountForm() | |||
| bf = form["emails"] | |||
| self.assertTrue(isinstance(bf, CompositeBoundField)) | |||
| self.assertEqual(len(bf), 0) | |||
| self.assertIsNone(bf.initial) | |||
| # self.assertEqual(len(bf), 0) | |||
There was a problem hiding this comment.
There is commented out code. I would suggest removing it.
Suggested change
| # self.assertEqual(len(bf), 0) |
|
I haven't tested anything locally on my machine. The changes look good so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for bringing django-superform into modern supported Django and Python