Replaces count by exists in populate_history command #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces a
count()
query inpopulate_history
command byexists()
Related Issue
#922
Motivation and Context
The
populate_history
command checks if historical records exist for each model. However, this check uses acount
query that can be expensive if the historical table is large. Anexists
query serves this purpose and is much faster to run.How Has This Been Tested?
I ran all tests using the runtests.py script and sqlite3 database.
The
populate_history
command is already tested by TestPopulateHistory TestCase and covers this change.Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst