-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve French translations #811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 18 18
Lines 992 992
Branches 151 151
=======================================
Hits 967 967
Misses 12 12
Partials 13 13 Continue to review full report at Codecov.
|
(CI not passing is due to docker timeout when pulling resources, and has nothing to do with this PR -it only contains translations) |
I reran and it worked fine. |
"X-Generator: Poedit 2.3\n" | ||
|
||
#: simple_history/admin.py:111 | ||
#: .\simple_history\admin.py:102 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all of the slashes now backslashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because sadly, path encoding depends on the platform gettext
is running on.
I'm not sure whether this is a big deal or not, as running makemessages
again on a GNU/Linux system would revert to /
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth overriding the makemessages
command to normalize the paths? Not sure why Django doesn’t do this by default (AFAIK, Unix-style paths work fine on Windows).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how 3rd-party translation tools manage with this.
Overriding makemessages
might be an idea, but it doesn't sound very project-specific to me. I guess Django preserves default gettext
behavior, as generally you'll run makemessages
on the platform you are translating on before making any edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(in the context of this somewhat trivial PR, I'll rather do a quick regex replace and not dive into a makemessages
override and the tests that it would need)
Description
As a native French speaker, I fixed a few spelling issues in the current translation.
Motivation and Context
The most important change is replacing
Annuler
withRétablir
(forRevert
), because the first translates toCancel
-which is very misleading, as you moght have guessed.How Has This Been Tested?
I'm using this fork on a project where it works like expected.
Types of changes
Checklist:
make format
command to format my code=>
make format
errors on my machine=>
make docs
errors on my machine=> non applicable
AUTHORS.rst
CHANGES.rst
=> minor change, I guess it's not required
=> some tests do not pass on my machine, but it's clearly unrelated