Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch bump for use_base_model_db -> 2.7.1 #546

Closed

Conversation

dopatraman
Copy link
Contributor

@dopatraman dopatraman commented Apr 15, 2019

Specifying a new patch version for the changes in #539

Description

  • Updated setup.cfg
  • Updated simple_history/__init__.py

Related PR

#539

Motivation and Context

The easiest way to reference the latest changeset from #539 would be a release tag.

How Has This Been Tested?

AFAIK, no tests apart from the ones in #539 are necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@dopatraman dopatraman changed the title Patch bump for user_base_model_db Patch bump for use_base_model_db Apr 15, 2019
@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #546 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          17       17           
  Lines         848      848           
  Branches      117      117           
=======================================
  Hits          829      829           
  Misses          8        8           
  Partials       11       11
Impacted Files Coverage Δ
simple_history/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f928c81...f2a501e. Read the comment docs.

@dopatraman
Copy link
Contributor Author

@rossmechanic @kseever

Sorry, I forgot to bump the version in the code. Apologies 😅

@dopatraman dopatraman changed the title Patch bump for use_base_model_db Patch bump for use_base_model_db -> 2.7.1 Apr 15, 2019
@rossmechanic
Copy link
Collaborator

@dopatraman. Working on bumping it myself. Decided we're going to make use_base_model_db default to False rather than true so that it's backward compatible with previous versions and note the issue with 2.7.0

@dopatraman
Copy link
Contributor Author

dopatraman commented Apr 15, 2019

@rossmechanic

use_base_model_db should default to True for backwards compatibility right? That way previous changes will default to the same database as the operational model.

Check out this comment:
#539 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants