Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated django.utils.six with six #526

Merged
merged 5 commits into from
Feb 6, 2019
Merged

replace deprecated django.utils.six with six #526

merged 5 commits into from
Feb 6, 2019

Conversation

erikvw
Copy link
Contributor

@erikvw erikvw commented Feb 6, 2019

Remove deprecated django.utils.six in favor of six

Description

Usage of the vendored library django.utils.six is expected to be removed in Django 3.0.

See Django 3.0 release notes

How Has This Been Tested?

This change does not change any functionality so current tests suffice.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          17       17           
  Lines         830      830           
  Branches      114      114           
=======================================
  Hits          811      811           
  Misses          8        8           
  Partials       11       11
Impacted Files Coverage Δ
simple_history/models.py 98.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11fa04a...937dc40. Read the comment docs.

Copy link
Collaborator

@rossmechanic rossmechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rossmechanic rossmechanic merged commit 2e7d9d3 into jazzband:master Feb 6, 2019
@erikvw erikvw deleted the django_utils_six branch February 6, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants