-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Django 3.2 #1344
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
+ Coverage 96.83% 96.98% +0.14%
==========================================
Files 24 24
Lines 1452 1457 +5
Branches 237 240 +3
==========================================
+ Hits 1406 1413 +7
Misses 24 24
+ Partials 22 20 -2 ☔ View full report in Codecov by Sentry. |
@tim-schilling Are you available to review this? I'm planning on opening a release PR after merging this 🙂 |
I'll to try to make time tomorrow morning, but no promises. Feel free to merge and release without it though! |
Great! No worries if it turns out otherwise :) I don't have the administrative permissions to merge without a review (assuming that's what you meant), but I can try requesting reviews from some of the other Jazzband members 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
If you have time, I'd suggest doing two releases. The first with all of the changes before dropping 3.2. Then another version that drops 3.2. That way anyone using 3.2 still can utilize the latest changes.
Though then again, it's a lot easier to just release it all together 😄
Nice thinking, let's do that! I'll open a release PR for 3.6.0 before merging this 🙂 We can do 3.7.0 (or 3.6.1? 4.0.0? The version history's relationship with semantic versioning seems slightly inconsistent 😅) with the changes from this PR - though I'm not sure that I see the usefulness of a release that only drops a dependency version used in our CI code..? 🤔 (..apart from removing the |
Eh, I think minor version changes are fine for both, so 3.7. |
Its EOL was passed last month (April 1st); see https://www.djangoproject.com/download/#supported-versions. The changes in `test_admin.py` were made to slightly reduce the amount of work required when dropping support for Django 4.2 in the future (also the previous comments contained a typo, and should have said "prior to Django 5.0" instead of "prior to Django 4.2").
Description
Django 3.2's EOL was passed last month (April 1st); see Django's supported versions.
Related Issue
None
Motivation and Context
Removing support for dependencies for which development has stopped.
How Has This Been Tested?
See the GitHub Actions test build.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst