Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Django 3.2 #1344

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

ddabble
Copy link
Member

@ddabble ddabble commented May 15, 2024

Description

Django 3.2's EOL was passed last month (April 1st); see Django's supported versions.

Related Issue

None

Motivation and Context

Removing support for dependencies for which development has stopped.

How Has This Been Tested?

See the GitHub Actions test build.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (733f4e0) to head (d163a5c).
Report is 16 commits behind head on master.

Current head d163a5c differs from pull request most recent head 75cc8ce

Please upload reports for the commit 75cc8ce to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   96.83%   96.98%   +0.14%     
==========================================
  Files          24       24              
  Lines        1452     1457       +5     
  Branches      237      240       +3     
==========================================
+ Hits         1406     1413       +7     
  Misses         24       24              
+ Partials       22       20       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddabble
Copy link
Member Author

ddabble commented May 25, 2024

@tim-schilling Are you available to review this? I'm planning on opening a release PR after merging this 🙂

@tim-schilling
Copy link
Contributor

I'll to try to make time tomorrow morning, but no promises. Feel free to merge and release without it though!

@ddabble
Copy link
Member Author

ddabble commented May 25, 2024

Great! No worries if it turns out otherwise :)

I don't have the administrative permissions to merge without a review (assuming that's what you meant), but I can try requesting reviews from some of the other Jazzband members 🙂

tim-schilling
tim-schilling previously approved these changes May 26, 2024
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

If you have time, I'd suggest doing two releases. The first with all of the changes before dropping 3.2. Then another version that drops 3.2. That way anyone using 3.2 still can utilize the latest changes.

Though then again, it's a lot easier to just release it all together 😄

@ddabble
Copy link
Member Author

ddabble commented May 26, 2024

If you have time, I'd suggest doing two releases. The first with all of the changes before dropping 3.2. Then another version that drops 3.2. That way anyone using 3.2 still can utilize the latest changes.

Nice thinking, let's do that! I'll open a release PR for 3.6.0 before merging this 🙂

We can do 3.7.0 (or 3.6.1? 4.0.0? The version history's relationship with semantic versioning seems slightly inconsistent 😅) with the changes from this PR - though I'm not sure that I see the usefulness of a release that only drops a dependency version used in our CI code..? 🤔 (..apart from removing the asgiref>=3.6 installation requirement, I guess)

@tim-schilling
Copy link
Contributor

Eh, I think minor version changes are fine for both, so 3.7.

Its EOL was passed last month (April 1st); see
https://www.djangoproject.com/download/#supported-versions.

The changes in `test_admin.py` were made to slightly reduce the amount
of work required when dropping support for Django 4.2 in the future
(also the previous comments contained a typo, and should have said
"prior to Django 5.0" instead of "prior to Django 4.2").
@ddabble ddabble merged commit 560f298 into jazzband:master May 29, 2024
17 checks passed
@ddabble ddabble deleted the drop-django-3.2 branch May 29, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants