Pagination and filtering (new PR) #1277
Open
+159
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update documentation make sure they pass tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci use history list per page instead of list per page paginator.get_page already has a default value Update docs/admin.rst Co-authored-by: Anders <[email protected]> get rid of duplicated code block in docs add test better test [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci pre commit hooks run
|
Any update on this? Do you need any help? |
|
@ddabble ? |
|
@jurrian Sorry for the (very) late reply; I'm busy with some of the other PRs, currently, but this is definitely on my TODO list 🙂 |
|
Hi guys! How is going this feature? I'm super engaged with that, for us would be an amazing deliveryHi guys! How is going this feature? I'm super engaged with that for us will be an amazing delivery |
|
Only needs review at the moment. Code should be complete, but needs to be tested and merged. |
tim-schilling
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will add pagination and filtering to the simple history admin view. This is needed because it will allow more performance views on instances with many historical records. Currently it is very likely to timeout depending on the settings.
It uses the same pagination as the default in Django.
Related Issue
This PR replaces this stale PR: #1220
Most of the text of this PR is copied from the stale one.
Closes #1117 and closes #1219.
Motivation and Context
This is needed because it will allow more performance views on instances with many historical records. Currently it is very likely to timeout depending on the settings .
How Has This Been Tested?
Added a few extra tests on top of what already existed in the stale PR.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst