Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MariaDB test container failing to start #1200

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Fix MariaDB test container failing to start #1200

merged 1 commit into from
Jul 2, 2023

Commits on Jul 2, 2023

  1. Replaced deprecated MySQL aliases for MariaDB tests 

    This fixes the recently failing GitHub Actions test workflows, in which
the MariaDB Docker container failed to start.

The issue seems to have been using the `mysqladmin` command for health
checking in `test.yml`, probably due to the following change in
MariaDB v11.0.1:
(Copied from https://mariadb.com/kb/en/mariadb-11-0-1-release-notes/)
"""
## Docker Official Images
* 11.0, unlike previous version, no longer includes mysql named
  compatible executable symlinks inside the container.
"""
https://mariadb.com/kb/en/mysqladmin/ mentions that `mariadb-admin` is
now the new name of the script (previously `mysqladmin`).

Also replaced the `MYSQL_DATABASE` and `MYSQL_ROOT_PASSWORD` environment
variables with their new names (based on the docs:
https://mariadb.com/kb/en/mariadb-server-docker-official-image-environment-variables/).
    @ddabble
    ddabble committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    359f68a View commit details
    Browse the repository at this point in the history