Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add id translation #1198

Merged
merged 4 commits into from
Jul 2, 2023
Merged

add id translation #1198

merged 4 commits into from
Jul 2, 2023

Conversation

kiraware
Copy link
Member

Description

Support Bahasa Indonesia translation

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

ddabble
ddabble requested changes Jul 1, 2023
View reviewed changes
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Just a couple minor requests:

simple_history/locale/id/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
simple_history/locale/id/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
kiraware and others added 2 commits July 2, 2023 16:13
@kiraware @ddabble
remove fuzzy
f8bce64 
Co-authored-by: Anders <[email protected]>
@kiraware @ddabble
add empty line
12510d3 
Co-authored-by: Anders <[email protected]>
@kiraware
Copy link
Member Author

kiraware commented Jul 2, 2023

Done @ddabble. Thanks for your response.

ddabble
ddabble approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

@ddabble ddabble merged commit 32d3dda into jazzband:master Jul 2, 2023
@kiraware kiraware deleted the add-id-translations branch July 3, 2023 02:51
@kiraware
Copy link
Member Author

kiraware commented Jul 3, 2023

Your welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddabble ddabble ddabble approved these changes

Assignees
No one assigned
Labels
translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiraware @ddabble