Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: missing comma in 'Signals' codeblock #1132

Merged
merged 3 commits into from
May 2, 2023

Conversation

hector97i
Copy link
Contributor

@hector97i hector97i commented Feb 23, 2023

Description

Added missing comma

Related Issue

#1133

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

CHANGES.rst Outdated Show resolved Hide resolved
@ddabble ddabble linked an issue Feb 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1132 (035b666) into master (4790591) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
+ Coverage   97.22%   97.30%   +0.07%     
==========================================
  Files          23       23              
  Lines        1263     1263              
  Branches      205      205              
==========================================
+ Hits         1228     1229       +1     
  Misses         16       16              
+ Partials       19       18       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ddabble ddabble added the docs label May 2, 2023
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ddabble ddabble merged commit f48bb89 into jazzband:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: missing comma in 'Signals' codeblock
2 participants