Fix failing tests #1124
Merged
Fix failing tests #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Django's `main` branch, the default value of the `USE_TZ` setting was changed from `False` to `True` (see django/django@602d9a3), which caused the tests relying on timezone-naive `datetime` objects, to fail. Example of some of the failing tests: https://github.com/jazzband/django-simple-history/actions/runs/4108104757/jobs/7088397467.
...to fix the remaining failing tests. This is due to Django's `main` branch now requiring Python >=3.10. Example of the errors: https://github.com/jazzband/django-simple-history/actions/runs/4108104757/jobs/7088396098.
These URLs were not updated when the `build` workflow was renamed to `test` (in 60beaf4).
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 23 23
Lines 1231 1231
Branches 199 199
=======================================
Hits 1197 1197
Misses 16 16
Partials 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
11 tasks
joshuadavidthomas
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to recent changes on Django's
mainbranch, Python versions 3.8 and 3.9 can no longer be tested with it, and theUSE_TZsettings needs to be explicitly set toFalse.Also fixed the non-rendering status badge for the
buildworkflow (later renamed toTest) inREADME.rst.Related Issue
Not deemed necessary.
Motivation and Context
Fixing the recently failing tests.
How Has This Been Tested?
Only through GitHub Actions.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst