Skip to content

Commit

Permalink
Replaced deprecated MySQL aliases for MariaDB tests (#1200)
Browse files Browse the repository at this point in the history
This fixes the recently failing GitHub Actions test workflows, in which
the MariaDB Docker container failed to start.

The issue seems to have been using the `mysqladmin` command for health
checking in `test.yml`, probably due to the following change in
MariaDB v11.0.1:
(Copied from https://mariadb.com/kb/en/mariadb-11-0-1-release-notes/)
"""
## Docker Official Images
* 11.0, unlike previous version, no longer includes mysql named
  compatible executable symlinks inside the container.
"""
https://mariadb.com/kb/en/mysqladmin/ mentions that `mariadb-admin` is
now the new name of the script (previously `mysqladmin`).

Also replaced the `MYSQL_DATABASE` and `MYSQL_ROOT_PASSWORD` environment
variables with their new names (based on the docs:
https://mariadb.com/kb/en/mariadb-server-docker-official-image-environment-variables/).
  • Loading branch information
ddabble authored Jul 2, 2023
1 parent ae6f25d commit a312dc6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ jobs:
mariadb:
image: mariadb:latest
env:
MYSQL_DATABASE: mariadb
MYSQL_ROOT_PASSWORD: mariadb
MARIADB_DATABASE: mariadb
MARIADB_ROOT_PASSWORD: mariadb
ports:
- 3307:3306
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
options: --health-cmd="mariadb-admin ping" --health-interval=10s --health-timeout=5s --health-retries=3

steps:
- uses: actions/checkout@v3
Expand Down

0 comments on commit a312dc6

Please sign in to comment.