One migration pending in 1.1.0

[truizsanchez]

Migrations doesn't reflect the current Request#prof_file attribute, so one migration is still pending to be generated. That difficulties working with the library in some CI and automated environments

[nasirhjafri]

Isn't 1.1.0 a very old release?

[truizsanchez]

Isn't 1.1.0 a very old release?

Hehe I know, but we have a legacy environment with django 1.7 and python 2.7...

[nasirhjafri]

Isn't 1.1.0 a very old release?

Hehe I know, but we have a legacy environment with django 1.7 and python 2.7...

This migration already exists in 1.1.0 https://github.com/jazzband/django-silk/blob/c9438044e59ae20da2406958b043a0f7fdce67e8/silk/migrations/0005_increase_request_prof_file_length.py

[truizsanchez]

Isn't 1.1.0 a very old release?

Hehe I know, but we have a legacy environment with django 1.7 and python 2.7...

This migration already exists in 1.1.0 https://github.com/jazzband/django-silk/blob/c9438044e59ae20da2406958b043a0f7fdce67e8/silk/migrations/0005_increase_request_prof_file_length.py

Yes, migration #5 is changing Request#prof_file attribute, but the problem is with storage attribute, is not evaluated in previous migrations, so in migration #6 is taking the default value:
defaults = {
...
'SILKY_STORAGE_CLASS': 'silk.storage.ProfilerResultStorage'
}

I do not know if you want to always have previously made makemigrations before using the library, but if that is the case it makes it difficult to work in certain automated environments, requiring additional steps to have the library ready to use.

Any criticism is welcome, I hope to be useful :)

[nasirhjafri]

Test cases are failing, please fix them. Even if we want to merge this one we can't backport it to 1.1.0.
That being said it would only be available in 4.0.1. I'll test it once the tests are passed.

[nasirhjafri]

Isn't 1.1.0 a very old release?

Hehe I know, but we have a legacy environment with django 1.7 and python 2.7...

This migration already exists in 1.1.0 https://github.com/jazzband/django-silk/blob/c9438044e59ae20da2406958b043a0f7fdce67e8/silk/migrations/0005_increase_request_prof_file_length.py

Yes, migration #5 is changing Request#prof_file attribute, but the problem is with storage attribute, is not evaluated in previous migrations, so in migration #6 is taking the default value:
defaults = {
...
'SILKY_STORAGE_CLASS': 'silk.storage.ProfilerResultStorage'
}

I do not know if you want to always have previously made makemigrations before using the library, but if that is the case it makes it difficult to work in certain automated environments, requiring additional steps to have the library ready to use.

Any criticism is welcome, I hope to be useful :)

So It was fixed later in v2.0.0 5ba0853

If you want to use it with v1.1.0 Please take a fork from v1.1.0 release tag and cherry-pick this commit on top of it 5ba0853

[truizsanchez]

Thank you, I made a mistake with branches bringing master...