Added utf8 in curl query parameters #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ilvar, I'll add the test case myself as the curl test cases are broken (hence the commenting out). I'll be doing a release with fixes for a few other issues also so will release this at the same time ;). |
mtford90
added a commit
that referenced
this pull request
Sep 18, 2014
Added utf8 in curl query parameters
pablodiazgutierrez
pushed a commit
to appfluence/django-silk
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem if GET parameters contain non-ASCII symbols.
/silk/request/ID/throws error 500 and complains onurlencode.That's known issue with
urlencode- it expects values in dict to be string, not unicode. So I've added explicit utf8-encoding here.Tests for CURL are all commented out, so no test here. I can add it as a separate
TestCase, if necessary.