Drop support for Django < 1.11 and remove workarounds #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Django's recommendation, as django-silk supports 2.0, it should drop support for Django < 1.11 to ease maintenance and compatibility across Django versions. So long as no deprecation warnings are produced, django-silk should remain forward compatible with the next Django version. For more details, see the Django docs: https://docs.djangoproject.com/en/2.0/releases/2.0/#third-party-library-support-for-older-version-of-django > Third-party library support for older version of Django > > Following the release of Django 2.0, we suggest that third-party app authors > drop support for all versions of Django prior to 1.11. At that time, you > should be able to run your package’s tests using python -Wd so that > deprecation warnings do appear. After making the deprecation warning fixes, > your app should be compatible with Django 2.0. Those wishing to continue using an older Django can pin the version django-silk. Should significantly reduce testing resources as the test matrix is much smaller.
avelis
approved these changes
Jan 29, 2018
|
@jdufresne Thank you for cleaning up this library and improving django-silks compatibility for Django 2.0 onward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Django's recommendation, as django-silk supports 2.0, it should drop support for Django < 1.11 to ease maintenance and compatibility across Django versions. So long as no deprecation warnings are produced, django-silk should remain forward compatible with the next Django
version.
For more details, see the Django docs:
https://docs.djangoproject.com/en/2.0/releases/2.0/#third-party-library-support-for-older-version-of-django
Those wishing to continue using an older Django can pin the version django-silk.
Should significantly reduce testing resources as the test matrix is much smaller.