Test django 2 in travis #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@albertyw I am seeing a couple of issues with TravisCI. It appears it can't seem to download Django 2. The other issue is that the projects url settings don't seem to pass certain versions of Django during the testing matrix. Might have to do conditional url patterns or drop the version that is not ok with the pattern change. |
|
@albertyw I also remember reading somewhere you wanted to cut a release. The version value is in |
albertyw
force-pushed
the
test-django-2
branch
6 times, most recently
from
78e55dd
to
b84b52a
Compare
Closed
albertyw
force-pushed
the
test-django-2
branch
from
b84b52a
to
1b7ec90
Compare
|
@albertyw Thanks again for working on this and getting the compatibility for Django 2 in this library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Django 2 to the list of django versions that travis will test against.
This still requires some work to fix various problems. Also depends on #232 and #231.