configurable storage class #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcoll
force-pushed
the
configurable_storage_class
branch
2 times, most recently
from
b89c0d4
to
a6d1453
Compare
smcoll
force-pushed
the
configurable_storage_class
branch
from
a6d1453
to
b42d670
Compare
|
Rebased. Note that the docs are updated and i've moved the default storage class to a new location. |
|
@smcoll Since this is introducing the concept of a customize-able storage. I am wondering if makes sense to add some config level tests asserting default behavior. Thoughts? |
|
Yes, i agree. i'll add a test asserting the default storage class is used when the setting is not specified. Would that be sufficient? |
|
@smcoll Yes that would be sufficient! |
|
@avelis added- does that work? |
|
@smcoll Yes. Works for me. Thanks again for adding the test. |
danielbradburn
pushed a commit
to crunchr/silk
that referenced
this pull request
Dec 8, 2017
* move ProfilerResultStorage to own module to resolve import * use SilkyConfig for SILKY_STORAGE_CLASS * terse storage definition * didn't mean to reorder imports * increase Request.prof_file max_length to 300 (jazzband#203) * test default storage class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #202