remove simplejson #105
Merged
remove simplejson #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitaldavenyc Thanks for your contribution. |
|
@avelis No problem, glad to help! |
|
@digitaldavenyc In regards to procedures. I don't have anything official other than passing unit tests on TravisCI. |
|
Ok good to know. And it's ok to request the pull request from master? |
|
@digitaldavenyc Absolutely! I do my best to tackle issues when I have time. However, I encourage contributions as much as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR here, not sure on procedures so let me know if anything else is needed. Submitting this PR to remove simplejson from requirements and setup.py. It doesn't seem to be used anywhere in the code base anymore and actually caused a failure in the requests library on our project because requests defaults to simplejson if available.