Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No cPython profiler dump visible #181

Closed
fuwaneko opened this issue Jun 13, 2017 · 2 comments
Closed

No cPython profiler dump visible #181

fuwaneko opened this issue Jun 13, 2017 · 2 comments
Labels
bug help wanted

Comments

@fuwaneko
Copy link

PR #171 introduced a regression. Below Silk Profiler should be cPython profiler dump. It is stored in the DB but isn't there in the template anymore. I wonder why nobody noticed this.

Current state:
image

Expected state:
image
@avelis
Copy link
Collaborator

avelis commented Jun 13, 2017

@fuwaneko Thanks for bringing this to my attention. If you have time to make a PR to fix the regression I happily encourage it. Otherwise I would have to get to this at a later time when I work on it.

aadu added a commit to aadu/silk that referenced this issue Jan 4, 2018
@aadu
Re-add missing Pyprofile dump to profiling template jazzband#181
782a98e
aadu added a commit to aadu/silk that referenced this issue Jan 4, 2018
@aadu
Re-add missing Pyprofile dump to profiling template jazzband#181
6a0b827
@SebCorbin
Copy link
Contributor

This seems to be fixed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fuwaneko @avelis @SebCorbin