-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add token prefix option #272
Conversation
I think this is a good idea :) Happy to take this on board with tests and docs |
@James1345 Added tests and docs. Feel free to review! |
@James1345 Hi! Could you give it another look? |
@James1345 Hi! Would be really cool to have it. I don't wanna spam you though, but maybe you could have another look. Just let me know, what to change or adjust. |
Hi, I'll try to remember to take a look this weekend. Feel free to drop me
a line if I haven't done as I'm pretty busy and forget to check this
regularly
…On Fri, 5 Aug 2022 at 16:10, Max Wittig ***@***.***> wrote:
@James1345 <https://github.com/James1345> Hi! Would be really cool to
have it. I don't wanna spam you though, but maybe you could have another
look. Just let me know, what to change or adjust.
—
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESG6VT46CV7AWELHKAQWLVXUVHBANCNFSM54ESRZ4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@James1345 Friendly ping. |
@max-wittig Approved, can you fix the merge conflicts and I'll merge it :) |
@James1345 Rebased. |
@James1345 Hi! I don't really wanna rebase one more time. Could we get it in please? 😄 |
Hi @max-wittig, yes I won't merge anything else until this one is done now - sorry for the trouble. Can you look at why the tests are failing though please? |
Tests fixed. |
Merged, I'll try to get a release done soon as we've had a few merges this month |
@James1345 Thank you!! |
Hi @belugame, @James1345
Thanks for creating
django-rest-knox
!This feature will add an optional token prefix to the library that can be used to detect these tokens easily and quickly revoke them in case they are leaked. The same mechanism is also used by GitHub and GitLab. See also the issue: #271
This is just a MR to see, if you would accept that feature. I will provide tests and documentation, once you approve.
Fixes #271
@dlouzan @bufferoverflow @fh1ch @nejch