-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openid Connect Core support - Round 2 #859
Conversation
…enID parameters to oauthlib.common.Request
…e to avoid validation security breach
…n_required to be 400 as changed in oauthlib/pull/623
ff31d8d
to
c93d677
Compare
Pull Request Test Coverage Report for Build 1423
💛 - Coveralls |
df36c10
to
af388c0
Compare
af388c0
to
1e8d66b
Compare
Hey there! Thanks for this PR; my team is very excited about getting started with it. Are there any examples or docs we could follow to get started? Happy to move to an issue as well if comments on closed PRs aren't permitted. |
@auvipy you've merged a significant bunch of changes but didn't request that the checklist be followed and @thinkwelltwd I'm wondering why this checklist is not in the PR description as it must have been templated there. Did you (inadvertently) remove it?:
Specifically I see a number of problems that will require a follow-up PR @thinkwelltwd:
Would @thinkwelltwd and/or @auvipy please submit a documentation PR to remediate this issue? I'm reluctant to push a new release with the master branch in the state it is right now. @auvipy I'm kind of disappointed as we've discussed this issue of merging before ready before. This lack of process would someone considering using this library to think twice about the quality of it. |
This will need to be re-opened/recreated as a new PR. |
I would like to use DOT, but need oidc support so I rebased shaun's PR onto wiliamsouza's PR and then rebased that onto master.
If it's not kosher to open another PR with other people's work, please let me know and I'll delete it. Otherwise, I would be very glad to get oidc support in this library.