refactor: just one URI validator #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 97.48% 97.54% +0.05%
==========================================
Files 32 32
Lines 2111 2120 +9
==========================================
+ Hits 2058 2068 +10
+ Misses 53 52 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dopry
force-pushed
the
refactor/just-one-uri-validator
branch
7 times, most recently
from
e8e80cb to
2dc944f
Compare
dopry
force-pushed
the
refactor/just-one-uri-validator
branch
from
2dc944f to
3da727f
Compare
n2ygk
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1336
Description of the Change
Add scheme validation with detailed error messaged to AllowedURIValidator, and use in place of RedirectURIValidator
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS