Fix the invalid_client error when request token without the client_secret field #1288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
Even after the PR #1276 if the request don't have the
client_secret
field the response will be:status_code: 401
{"error": "invalid_client"}
Demo image
The only way to retrieve the token is sending the client_secret field as an empty string:
Demo image
This PR is to allow the first case (request without a client_secret field) to work accordingly to the RFC specification
Reason
The Oauthlib Request object always have the client_secret param initialized as None, so
getattr(request, "client_secret", "")
will return None intead of the empty string even if the original request doesn't send the parameter, this is why I added theor ""
at the end of this line.Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS