-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions. #358
Conversation
- Stop using test_suite in setup.py. - Get rid of the requirements files. - Add tox.ini.
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=========================================
Coverage ? 86.02%
=========================================
Files ? 16
Lines ? 1302
Branches ? 137
=========================================
Hits ? 1120
Misses ? 135
Partials ? 47 Continue to review full report at Codecov.
|
@claudep Hey, I've added you as well since you've done some work on this library and I want to make sure we move this along. This is fully in line what all the other Jazzband projects have done FWIW. |
Sorry, I'm no longer active on django-newsletter. |
Got it, thank you! |
@aleksihakli Apologies for pulling you into this, I want to move ahead with this pull request and your review would be much appreciated! |
Hey @jezdez! I've been a bit busy but I'll review this today. Feel free to ping me via mail or on GitHub in case you need any help, I'll happily assist if I have the bandwidth :) |
Understood and no problem, thank you for getting back to me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! setup.py
package classifiers should probably also include Python 3.9 and possibly Django version classifiers?
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
It drops support for Python 3.5 because GitHub Actions doesn't fully support them. It's EOL anyway.
Python 3.9 support is also added.
This also relates to #343 in that it enables the release workflow mentioned there with @dokterbob as proejct lead. The version is deducted from the last git tag automatically using setuptools_scm.
TODO:
JAZZBAND_RELEASE_KEY
to the repo secrets.