Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excerpt field workaround for South FakeORM #610

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

mthuurne
Copy link
Contributor

@mthuurne mthuurne commented Apr 9, 2024

South FakeORM hasn't been supported since fda2d39, but the workaround introduced in 9147bec evaded deletion. The NoRendered model was removed in 9df3df9, but with that model gone, the no_excerpt_field argument became obsolete as well.

South FakeORM hasn't been supported since fda2d39, but the workaround
introduced in 9147bec evaded deletion. The `NoRendered` model was
removed in 9df3df9, but with that model gone, the `no_excerpt_field`
argument became obsolete as well.
@mthuurne mthuurne mentioned this pull request Apr 9, 2024
@foarsitter
Copy link
Contributor

Can you add an entry to the change log? Something like

SplitField no longer accepts no_excerpt_field as keyword argument

@foarsitter foarsitter merged commit a86c14e into jazzband:master Apr 10, 2024
7 checks passed
@mthuurne mthuurne deleted the remove-no_excerpt_field branch April 10, 2024 12:20
mthuurne added a commit to ProtixIT/django-model-utils that referenced this pull request Apr 10, 2024
* Remove excerpt field workaround for South FakeORM

South FakeORM hasn't been supported since fda2d39, but the workaround
introduced in 9147bec evaded deletion. The `NoRendered` model was
removed in 9df3df9, but with that model gone, the `no_excerpt_field`
argument became obsolete as well.

* Document removal of `no_excerpt_field` in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants