Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead init_deferred_fields method #580

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

joecox
Copy link
Contributor

@joecox joecox commented Sep 11, 2023

Problem

The init_deferred_fields method, added in 6ffae1a, had its only usage removed in e6c7b56.

Solution

Remove the init_deferred_fields method, along with the now-unused DescriptorMixin.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@joecox
Copy link
Contributor Author

joecox commented Sep 11, 2023

Given that this is removal of dead code, which doesn't affect any documented feature, I opted not to update CHANGES.rst. I can do that if needed.

@foarsitter foarsitter merged commit 7b8a58b into jazzband:master Mar 21, 2024
@foarsitter
Copy link
Contributor

Thanks @joecox

@foarsitter foarsitter added this to the 4.5.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants