Field tracker patch save: failing test and fix #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRigal
force-pushed
the
field-tracker-patch-save
branch
from
78f19e8
to
29a56c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 94.70% 94.83% +0.13%
==========================================
Files 6 6
Lines 774 775 +1
==========================================
+ Hits 733 735 +2
+ Misses 41 40 -1
Continue to review full report at Codecov.
|
tests: Add failing test for case tracker used after super().save() tests: Add failing test for case tracker used after super().save() fix: Add foo fix: Flake8
MRigal
force-pushed
the
field-tracker-patch-save
branch
from
29a56c7
to
68f7404
Compare
|
Closing in favor of #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Breaking change behaviour on FieldTracker, see #491
Solution
Going back to patch the
save()and not thesave_base()method. Adding an extra parameter to keep the feature introduced with handlingupdate_fieldsCommandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.