Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry for package management. #179

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

valberg
Copy link
Contributor

@valberg valberg commented Apr 4, 2022

This should be merged before #178

A lot of credit goes to @MrCordeiro and his changes in https://github.com/MrCordeiro/django-invitations

@valberg valberg force-pushed the change_to_poetry branch from 088338d to 25fb378 Compare April 4, 2022 11:27
@valberg valberg marked this pull request as draft April 4, 2022 11:27
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ab92147). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage          ?   64.64%           
=========================================
  Files             ?       17           
  Lines             ?      478           
  Branches          ?        0           
=========================================
  Hits              ?      309           
  Misses            ?      169           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab92147...64f063a. Read the comment docs.

@valberg valberg requested a review from MrCordeiro April 4, 2022 11:28
@valberg valberg marked this pull request as ready for review April 4, 2022 13:10
@valberg valberg merged commit b2c2a82 into jazzband:master Apr 4, 2022
@jezdez
Copy link
Member

jezdez commented Sep 28, 2022

@valberg @MrCordeiro FWIW I haven't tested the Jazzband index with Poetry, so this may or may not fail.

repository_url: https://jazzband.co/projects/django-invitations/upload
run: |
poetry config repositories.jazzband https://jazzband.co/projects/django-invitations/upload
poetry config http-basic.jazzband jazzband ${{ secrets.JAZZBAND_RELEASE_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this won't actually upload the file, @valberg! It just configures it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valberg, we're missing a publish step:

    - name: Upload packages to Jazzband
        if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
        uses: pypa/gh-action-pypi-publish@master
        with:
          user: jazzband
          password: ${{ secrets.JAZZBAND_RELEASE_KEY }}
          repository_url: https://jazzband.co/projects/wagtailmenus/upload 

(I'm curious to see if building it with poetry will work. Perhaps using poetry publish instead could work too?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#195 fixed this FWIW

jezdez added a commit that referenced this pull request Sep 28, 2022
This was a regression introduced in #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants