-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poetry for package management. #179
Conversation
088338d
to
25fb378
Compare
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage ? 64.64%
=========================================
Files ? 17
Lines ? 478
Branches ? 0
=========================================
Hits ? 309
Misses ? 169
Partials ? 0 Continue to review full report at Codecov.
|
@valberg @MrCordeiro FWIW I haven't tested the Jazzband index with Poetry, so this may or may not fail. |
repository_url: https://jazzband.co/projects/django-invitations/upload | ||
run: | | ||
poetry config repositories.jazzband https://jazzband.co/projects/django-invitations/upload | ||
poetry config http-basic.jazzband jazzband ${{ secrets.JAZZBAND_RELEASE_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, this won't actually upload the file, @valberg! It just configures it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valberg, we're missing a publish step:
- name: Upload packages to Jazzband
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
uses: pypa/gh-action-pypi-publish@master
with:
user: jazzband
password: ${{ secrets.JAZZBAND_RELEASE_KEY }}
repository_url: https://jazzband.co/projects/wagtailmenus/upload
(I'm curious to see if building it with poetry will work. Perhaps using poetry publish
instead could work too?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#195 fixed this FWIW
This was a regression introduced in #179
This should be merged before #178
A lot of credit goes to @MrCordeiro and his changes in https://github.com/MrCordeiro/django-invitations