Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #174

Merged
merged 8 commits into from
Mar 30, 2022
Merged

Fix tests #174

merged 8 commits into from
Mar 30, 2022

Conversation

valberg
Copy link
Contributor

@valberg valberg commented Mar 30, 2022 •
edited
Loading

This fixes tests and brings django-invitations into a state where only supported versions of django and python are supported.

My suggestion is that we bump the release version of django-invitations to be 2.0 for the next release.

Closes #167 and #153

@valberg valberg closed this Mar 30, 2022
@valberg valberg deleted the fix_tests_for_django_4.0 branch March 30, 2022 13:21
@valberg valberg restored the fix_tests_for_django_4.0 branch March 30, 2022 13:58
@valberg valberg reopened this Mar 30, 2022
@valberg valberg changed the title Use path in test_urls.py Fix tests Mar 30, 2022
@valberg valberg marked this pull request as draft March 30, 2022 14:03
@valberg valberg force-pushed the fix_tests_for_django_4.0 branch from e1124e5 to 4a3971e Compare March 30, 2022 14:18
@valberg valberg requested a review from brylie March 30, 2022 14:42
@valberg valberg marked this pull request as ready for review March 30, 2022 14:43
@valberg valberg linked an issue Mar 30, 2022 that may be closed by this pull request
Django 4.0 compatibility (deprecation warnings added in v3.1) #153
Closed
@valberg valberg mentioned this pull request Mar 30, 2022
Closed
12 tasks
@valberg valberg requested a review from MrCordeiro March 30, 2022 15:29
MrCordeiro
MrCordeiro requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@MrCordeiro MrCordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still new a .pre-commit-config.yaml file before the build succeeds.

Since there is no code/isort style yet, I think this would suffice:

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.1.0
    hooks:
      - id: check-merge-conflict

@valberg
Copy link
Contributor Author

valberg commented Mar 30, 2022

@MrCordeiro I have another PR for pre-commit: #175

@valberg valberg mentioned this pull request Mar 30, 2022
Merged
@valberg valberg merged commit 1a513f5 into jazzband:master Mar 30, 2022
@valberg valberg deleted the fix_tests_for_django_4.0 branch March 30, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCordeiro MrCordeiro MrCordeiro approved these changes

@brylie brylie brylie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate which Django versions are supported Django 4.0 compatibility (deprecation warnings added in v3.1)
3 participants
@valberg @brylie @MrCordeiro