Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codebase to python3 #207

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

sevdog
Copy link
Contributor

@sevdog sevdog commented Sep 26, 2023

Remove python2 super and drop useless method redefinitions.

@Natim
Copy link
Collaborator

Natim commented Sep 26, 2023

Thank you @sevdog

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (338e171) to head (ff5073d).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
django_downloadview/files.py 50.00% 1 Missing ⚠️
django_downloadview/nginx/middlewares.py 50.00% 1 Missing ⚠️
django_downloadview/storage.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   85.51%   85.55%   +0.03%     
==========================================
  Files          72       72              
  Lines        1312     1308       -4     
==========================================
- Hits         1122     1119       -3     
+ Misses        190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevdog
Copy link
Contributor Author

sevdog commented Sep 26, 2023

I just came across this and was forced to do a couple of updates to better handle my usecase (see https://github.com/sevdog/django-downloadview/tree/updated), I tried to keep single changes to small PRs. If anything else is welcome I will arrange new PRs.

@tari
Copy link
Contributor

tari commented Jul 30, 2024

Nobody seems to have objected to these changes and I think they're good to have, so I'm going to go ahead and merge this.

@tari tari merged commit fba10f7 into jazzband:master Jul 30, 2024
17 of 18 checks passed
@sevdog sevdog deleted the improve-py3-code branch July 30, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants