Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of middleware settings #206

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sevdog
Copy link
Contributor

@sevdog sevdog commented Sep 26, 2023

Since this library is tested only against django>=2.2, there are no reason to keep using the old-style MIDDLEWARE_CLASSES settings whose support was removed in django 2.0.

@@ -51,7 +51,7 @@ Setup XSendfile middlewares
***************************

Make sure ``django_downloadview.SmartDownloadMiddleware`` is in
``MIDDLEWARE_CLASSES`` of your `Django` settings.
``MIDDLEWAR`` of your `Django` settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: MIDDLEWARE

@tari
Copy link
Contributor

tari commented Jul 30, 2024

Thanks for the change! Just one typo if you don't mind fixing that. :)

@sevdog sevdog force-pushed the upgrade-middleware-doc branch from 1a8be9a to c517202 Compare July 30, 2024 11:02
@sevdog
Copy link
Contributor Author

sevdog commented Jul 30, 2024

Typo fixed.

@tari tari merged commit 16b241d into jazzband:master Jul 30, 2024
16 of 18 checks passed
@sevdog sevdog deleted the upgrade-middleware-doc branch July 30, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants