Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated app_index.html #238

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

ataylor32
Copy link
Contributor

django-defender's app_index.html template is based on some old version of Django's app_index.html template. It's just like the one used in many versions of Django prior to 3.1 except that its indentation is different and it doesn't contain {% block bodyclass %}{{ block.super }} app-{{ app_label }}{% endblock %}. This has worked fine for anyone not relying on the bodyclass block being present. However, as of Django 4.2.1, the breadcrumbs are handled differently (compare Django 4.2's app_index.html template with Django 4.2.1's app_index.html template). Rather than trying to keep django-defender's app_index.html template in sync with Django's, it's probably better to just extend Django's.

Copy link
Collaborator

@kencochrane kencochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a972dae) 92.78% compared to head (af29fa5) 92.78%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          386      386           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kencochrane kencochrane merged commit c290b5a into jazzband:master Feb 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants