Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse options with numerical values as int #225

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

estahn
Copy link
Contributor

@estahn estahn commented Aug 15, 2023

fixes #222

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #225 (5a79985) into master (a7f94c8) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           69        72    +3     
  Branches        16        16           
=========================================
+ Hits            69        72    +3     
Files Changed Coverage Δ
dj_database_url/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@estahn
Copy link
Contributor Author

estahn commented Aug 15, 2023

@mattseymour 👋🏼 Can I get you to have a look at this?

@estahn
Copy link
Contributor Author

estahn commented Aug 15, 2023

If this can not be generalised we could have an index of options that require conversion to int.

@woodsae
Copy link

woodsae commented Aug 15, 2023

Amazing, I've been waiting for this fix!

@mattseymour mattseymour merged commit 13be1aa into jazzband:master Aug 15, 2023
13 checks passed
@mattseymour
Copy link
Contributor

Nice one, I am going to start building a v2.1.0 release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option value connect_timeout returned as string instead of int
3 participants