-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPTIONS
key type for DBConfig
is potentially incorrect
#218
Comments
palfrey
added a commit
to palfrey/dj-database-url
that referenced
this issue
Nov 8, 2023
As per the notes in jazzband#218
#232 will fix this |
palfrey
added a commit
to palfrey/dj-database-url
that referenced
this issue
Dec 9, 2023
As per the notes in jazzband#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2.0.0
introducesDBConfig
as aTypedDict
, specified as:As far as I can tell from a cursory reading of
parse
, it cannot beOptional
(None
) -options
is always at least an empty directory ({}
), but it can beNotRequired
as a key (which is AFAIK already handled by the class beingtotal=False
) because if it is empty it just won't be set.This came up for me because I have some code which does:
which gets raised as an error:
Here's the totality of
options
being used and then potentially bound to theOPTIONS
key:dj-database-url/dj_database_url/__init__.py
Lines 159 to 182 in 9b0f325
The text was updated successfully, but these errors were encountered: