Merge pull request #63 from jazz-community/Fix-conversion-CSV-import

Fix conversion csv import
jazz-community · Feb 16, 2024 · e74a085 · e74a085
2 parents 3bfdf7c + 1c72f4a
commit e74a085
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/...dline/src/main/java/com/ibm/js/team/workitem/commandline/helper/WorkItemUpdateHelper.java b/...dline/src/main/java/com/ibm/js/team/workitem/commandline/helper/WorkItemUpdateHelper.java
@@ -653,10 +653,10 @@ private Object getRepresentation(ParameterValue parameter, List<Exception> excep
 						isEmpty = true;
 					}
 					if (attribType.equals(AttributeTypes.INTEGER)) {
-						return Integer.getInteger(value);
+						return Integer.valueOf(value);
 					}
 					if (attribType.equals(AttributeTypes.LONG)) {
-						return Long.getLong(value);
+						return Long.valueOf(value);
 					}
 					if (attribType.equals(AttributeTypes.FLOAT)) {
 						return Float.parseFloat(value);
@@ -2727,9 +2727,17 @@ private void setWorkFlowAction(ParameterValue parameter) throws TeamRepositoryEx
 	 *         representation like "1 hour 3 minutes"
 	 */
 	private long getDurationFromString(String value) {
-		return SimpleDateFormatUtil.convertDurationToMiliseconds(value);
+		long duration;
+		try {
+			duration = SimpleDateFormatUtil.convertDurationToMiliseconds(value);
+		} catch (Exception e) {
+			throw new WorkItemCommandLineException(
+					"can not convert duration, value was: " + value, e);
+		}
+		return duration;
 	}
-
+
+
 	/**
 	 * Gets a list of Tags
 	 * 

diff --git a/...ndline/src/main/java/com/ibm/js/team/workitem/commandline/utils/SimpleDateFormatUtil.java b/...ndline/src/main/java/com/ibm/js/team/workitem/commandline/utils/SimpleDateFormatUtil.java
@@ -114,19 +114,19 @@ public static Long convertDurationToMiliseconds(String duration) {
 		int hoursIndex = duration.indexOf(DURATION_HOURS);
 		int minsIndex = duration.indexOf(DURATION_MINUTES);
 		if (hoursIndex < 0 && minsIndex < 0) {
-			return Long.getLong(duration);
+			return Long.valueOf(duration);
 		}
 		if (hoursIndex > 0) {
 			String hours = duration.substring(0, hoursIndex - 1).trim();
-			time += TimeUnit.HOURS.toMillis(Long.getLong(hours));
+			time += TimeUnit.HOURS.toMillis(Long.valueOf(hours));
 		}
 		if (minsIndex > 0) {
 			int start = 0;
 			if (hoursIndex > 0) {
 				start = hoursIndex + DURATION_HOURS.length();
 			}
 			String minutes = duration.substring(start, duration.length() - DURATION_MINUTES.length()).trim();
-			time += TimeUnit.MINUTES.toMillis(Long.getLong(minutes));
+			time += TimeUnit.MINUTES.toMillis(Long.valueOf(minutes));
 		}
 		return time;
 	}

diff --git a/...em.commandline/src/main/java/com/ibm/js/team/workitem/commandline/utils/WorkItemUtil.java b/...em.commandline/src/main/java/com/ibm/js/team/workitem/commandline/utils/WorkItemUtil.java
@@ -38,9 +38,9 @@ public class WorkItemUtil {
 	 */
 	public static IWorkItem findWorkItemByID(String id, ItemProfile<IWorkItem> profile, IWorkItemCommon workitemCommon,
 			IProgressMonitor monitor) throws TeamRepositoryException {
-		Integer idVal;
+		Integer idVal=null;
 		try {
-			idVal = Integer.getInteger(id);
+			idVal = Integer.valueOf(id);
 		} catch (NumberFormatException e) {
 			throw new WorkItemCommandLineException(" WorkItem ID: Number format exception, ID is not a number: " + id);
 		}