validate Category identifier to prevent assertation error

jazz-community · Jun 2, 2017 · 6a68ff7 · 6a68ff7
1 parent cfeedab
commit 6a68ff7
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/...ava/com/siemens/bt/jazz/services/WorkItemBulkMover/bulkMover/helpers/CategoryHelpers.java b/...ava/com/siemens/bt/jazz/services/WorkItemBulkMover/bulkMover/helpers/CategoryHelpers.java
@@ -4,6 +4,7 @@
 import com.ibm.team.repository.common.TeamRepositoryException;
 import com.ibm.team.repository.service.IRepositoryItemService;
 import com.ibm.team.repository.service.TeamRawService;
+import com.ibm.team.workitem.common.internal.util.CategoriesHelper;
 import com.ibm.team.workitem.common.model.CategoryId;
 import com.ibm.team.workitem.common.model.ICategory;
 import com.ibm.team.workitem.common.model.ICategoryHandle;
@@ -32,9 +33,11 @@ public static final AttributeValue getCategory(Object t_val,
     public static final void setCategory(IWorkItem workItem, String categoryId,
                             IWorkItemServer workItemServer, IProgressMonitor monitor) throws TeamRepositoryException {
         IProjectAreaHandle ipa = workItem.getProjectArea();
-        CategoryId cid =  CategoryId.createCategoryId(categoryId);
-        ICategoryHandle cat = workItemServer.findCategoryById2(ipa, cid, monitor);
-        workItem.setCategory(cat);
+        if(isValidCategoryId(categoryId)) {
+            CategoryId cid =  CategoryId.createCategoryId(categoryId);
+            ICategoryHandle cat = workItemServer.findCategoryById2(ipa, cid, monitor);
+            workItem.setCategory(cat);
+        }
     }
 
     public static final List<AttributeValue> addCategoriesAsValues(IProjectAreaHandle pa,
@@ -51,4 +54,8 @@ public static final List<AttributeValue> addCategoriesAsValues(IProjectAreaHandl
         }
         return values;
     }
+
+    public static boolean isValidCategoryId(String string) {
+        return string.startsWith("/") && string.indexOf("/", "/".length()) != -1;
+    }
 }