Skip to content

Commit

Permalink
Add id to assembly fixes #10
Browse files Browse the repository at this point in the history
Changing versions of the maven-assembly-plugin broke the build when
using newer versions. Versions after 2.4.1 (which is actually an ancient
version) require an assembly description to have an id. Set id to
'update-site-assembly' and set 'appendAssemblyId' to false. This uses a
correct id for the build, but stops maven from appending the id to the
finished zip. Just makes the file name unncesserily long and adds no
value.

I don't really know why this hasn't broken the build before, because we
never actually used a version older than 2.4.1. Will very likely be a
problem in builds that inherited from this project.
  • Loading branch information
SBI- committed May 17, 2017
1 parent e04738f commit 7d25ce7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/main/resources/archetype-resources/update-site/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<configuration>
<appendAssemblyId>false</appendAssemblyId>
<descriptors>
<descriptor>templates/zip.xml</descriptor>
</descriptors>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0 http://maven.apache.org/xsd/assembly-1.1.0.xsd">
<id>update-site-assembly</id>
<baseDirectory>/</baseDirectory>
<formats>
<format>zip</format>
Expand Down

0 comments on commit 7d25ce7

Please sign in to comment.