Review PR. DO NOT MERGE #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rse locator and a ccx id.
…urseLocator as the course_key value
|
Changes Unknown when pulling d1c6b2e on master into * on original-commit*. |
| version_guid=None, | ||
| deprecated=False, | ||
| **kwargs | ||
| ): |
There was a problem hiding this comment.
You shouldn't need to explicitly list out all of the keyword arguments that are consumed by super(CCXLocator, self).__init__(...). If you just took kwargs, and then passed those kwargs to the super call, everything would work, I think.
|
Changes Unknown when pulling 582735c on master into * on original-commit*. |
|
Changes Unknown when pulling 5c73556 on master into * on original-commit*. |
…ys from this ccx key. Ensures we have control over how they are created
Not much fun doing all this way out in the open like this. A bit embarassing
|
Changes Unknown when pulling 827f293 on master into * on original-commit*. |
…ormal BlockUsageLocator. In keeping with the idea of a 'neutral' or 'course-local' version of ccx keys
|
Changes Unknown when pulling 633b28f on master into * on original-commit*. |
|
Changes Unknown when pulling 81d071a on master into * on original-commit*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created to facilitate the code review required for https://github.com/edx/edx-platform/pull/8259