Drop @ratelimit Annotation, Create #[RateLimit] Attribute, Drop php7 support, Drop symfony 3 & 4 support #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also forget to mention "Drop sensio/framework-extra-bundle" |
|
Hum, looks like upload coverage is also broken for main repository... |
|
Something wrong with that pull request ? |
goetas
requested changes
Aug 11, 2023
added 4 commits
August 14, 2023 09:45
…support, Drop symfony 3 & 4 support
goetas
approved these changes
Aug 14, 2023
|
@axi thanks a lot. while solving the conflicts i had to rebase your branch, but now somehow github show my face on the commit despite the fact that the commit is authored by you. 😕 |
|
@goetas no worries, thanks for mentioning it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #130.
There is still (at least) one thing I would like somebody to check: the way I get Attributes in
RateLimitAnnotationListener::getRateLimitsFromAttributes(). I kind of mixed the ways I found inSymfony\Component\HttpKernel\Event\ControllerEvent::setController()&Symfony\Component\HttpKernel\Event\ControllerEvent::getAttributes()(sf6). I should maybe try to use getAttributes() method from ControllerEvent if it exists (sf6) and use my current implementation as a fallback for Sf5.4 ?I tried to make it the most compatible possible.
Also, I added a condition for uploading coverage in ci but I must verify it still works for non forks.
Let me know what you think.