Skip to content

Commit

Permalink
settings: retire changefeed lagging ranges settings
Browse files Browse the repository at this point in the history
These settings were added to 23.1 and 22.2 in patch versions via cockroachdb#110963 and cockroachdb#110970. These settings
will not exists in 23.2 onwards, so this commit adds them to the retired settings list for 23.2.

Release note: None
Epic: None
  • Loading branch information
jayshrivastava committed Sep 27, 2023
1 parent 4b2badd commit 1472bec
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/settings/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ var retiredSettings = map[InternalKey]struct{}{
"timeseries.storage.30m_resolution_ttl": {},
"server.cpu_profile.enabled": {},
"kv.rangefeed.catchup_scan_concurrency": {},
"changefeed.lagging_ranges_threshold": {},
"changefeed.lagging_ranges_polling_rate": {},
}

// sqlDefaultSettings is the list of "grandfathered" existing sql.defaults
Expand Down

0 comments on commit 1472bec

Please sign in to comment.