Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deno lsp support for vim-easycomplete #142

Closed
jayli opened this issue Feb 10, 2022 · 9 comments
Closed

add deno lsp support for vim-easycomplete #142

jayli opened this issue Feb 10, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@jayli
Copy link
Owner

jayli commented Feb 10, 2022

deno lsp: https://morioh.com/p/84a54d70a7fa

deno lsp 的 completion/signature/lint 是 ok 的,documentation 不可用

重点是两个问题:

  1. 要解决和 tsserver 之间的冲突
  2. import url 的获取
@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

之前没有考虑如果两个 lsp 共存时的情况,在实现 deno lsp 时就不能单以文件类型来判断 lsp 了,这里在 lsp enable() 时加了一个过滤,以后再考虑多个 lsp 共存时的代码重构。

call easycomplete#lsp#enable()

@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

对于 deno lsp 安装比较简单,通过 "InstallLSPServer"会遇到两个问题,第一个是从 github 下载比较慢,另一个是本地权限问题,有时候会弹出框

在系统设置里设置一下:

再次运行时还会弹框的话,直接点击打开即可

自己手工安装则没有这个问题。

@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

关于 deno 项目的识别:

基于 deno.jsonnode_modules以及 .vscode目录来判断。

是否需要增加 ast 级别的判断(TODO)?

@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

perfect

@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

11b5151

新增对 .vscode/settings.jsondeno.enable 的配置判断,很好的兼容 vscode 项目

@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

对于 deno lsp 安装比较简单,通过 "InstallLSPServer"会遇到两个问题,第一个是从 github 下载比较慢,另一个是本地权限问题,有时候会弹出框

在系统设置里设置一下:

再次运行时还会弹框的话,直接点击打开即可

自己手工安装则没有这个问题。

试了下,脚本curl下载安装包的话不会有弹框

@jayli
Copy link
Owner Author

jayli commented Feb 11, 2022

f1e5ce8

新增 DenoCache 命令,更新依赖

@jayli jayli added the enhancement New feature or request label Feb 11, 2022
@jayli jayli changed the title deno support add deno lsp support for vim-easycomplete Feb 12, 2022
@jayli
Copy link
Owner Author

jayli commented Feb 12, 2022

@jayli
Copy link
Owner Author

jayli commented Feb 15, 2022

related to #150

@jayli jayli closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant