-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli tester #32
Merged
feat: cli tester #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new CLI testing feature, including a new 'test' command and associated functionality. It also includes some refactoring and improvements to existing code. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jaykv - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider more specific exception handling in the
test
function to avoid masking important errors. - The test output formatting could be improved for better readability, especially for failed tests.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟡 Testing: 2 issues found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli test <manifest path>
Summary by Sourcery
Add a new CLI command
test
to execute tests defined in a manifest, enhance the manifest schema to include atests
section, and introduce aTester
class to support CLI testing. Refactor theCLIManifestReloader
toReloader
for improved code clarity.New Features:
test
to run tests defined in a manifest file, allowing users to execute and validate CLI commands through specified test scripts.Enhancements:
tests
section to the CLI manifest schema to define command tests, enabling structured testing of CLI commands.CLIManifestReloader
class toReloader
for a more generic implementation.Tests:
Tester
class to facilitate the execution of CLI tests, including methods to invoke tests and validate command execution.