Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larger intervals show marked decrease in speed of output #4

Closed
jayjanssen opened this issue Mar 5, 2015 · 3 comments
Closed

larger intervals show marked decrease in speed of output #4

jayjanssen opened this issue Mar 5, 2015 · 3 comments
Milestone

Comments

@jayjanssen
Copy link
Owner

No description provided.

@jayjanssen
Copy link
Owner Author

Concept:

modify parser to gather raw samples in their entirety and check the uptime value against the desired interval. Only parse the raw samples if we know we care about the interval, just toss it otherwise.

jayjanssen pushed a commit that referenced this issue Jun 17, 2015
@jayjanssen
Copy link
Owner Author

Also 2898525

@jayjanssen
Copy link
Owner Author

Before this fix:

BenchmarkParseStatus        2000       1088392 ns/op
BenchmarkParseVariables     2000        642497 ns/op
BenchmarkParseManySamples          5     234505434 ns/op
BenchmarkParseManySamplesLongInterval          5     233892328 ns/op
BenchmarkVariableExpand     2000        618501 ns/op

After

BenchmarkParseStatus        1000       1303638 ns/op
BenchmarkParseVariables     2000        611017 ns/op
BenchmarkParseManySamples          5     227013783 ns/op
BenchmarkParseManySamplesLongInterval         10     169662651 ns/op
BenchmarkVariableExpand     2000        617166 ns/op

I expect the improvement in BenchmarkParseManySamplesLongInterval should increase with the size of the interval. The new structure is somewhat more expensive to parse a single sample

@jayjanssen jayjanssen modified the milestone: v0.6 Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant